Sessions: dual-read legacy formats with corruption diagnostics - #182
Merged
Conversation
Owner
Author
Review: approved ✅Scope: read-side session compatibility only — no writes, no migration. That separation is the right call and is what makes this safe to land ahead of #185's canonical writer. What I checked
Note: this PR deliberately leaves canonical write normalization and single-writer ownership to #185. Reviewing them together, the split holds — nothing here presumes the writer contract. Validation: CI green. |
This was referenced Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
pnpm docs:checkpnpm lint(3 pre-existing warnings, 0 errors)pnpm format:checkpnpm typecheckpnpm testpnpm buildcargo check --manifest-path apps/desktop/src-tauri/Cargo.tomlcargo test --manifest-path apps/desktop/src-tauri/Cargo.toml(31 passed)Stack
Depends on #181 and #180. This is the read/diagnostics slice of PR 2; canonical write normalization and single-writer ownership remain separate follow-ups.